Yuti-G commented on PR #843:
URL: https://github.com/apache/lucene/pull/843#issuecomment-1112633027

   Hi @gsmiller, thanks for your feedback! Yes, I was proposing keeping the 
existing behavior of getTopChildren but utilizing the top-n param, as I thought 
it would safe because we would not break the current use cases, but you are 
absolutely right that we should stick with what top-n means here. 
   
   Please correct me if misunderstood your proposal. Are you suggesting that I 
add another getAllChildren API to retain the current behavior of 
getTopChildren, and then fix getTopChildren by returning ranges sorted by 
counts, or do you mean we should just keep this API untouched? Thanks!
   
   Best,
   Yuting


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to