rmuir opened a new pull request, #832: URL: https://github.com/apache/lucene/pull/832
This annotation is such an antipattern, it is so harmful to our codebase. * gives the impression that "slow tests are ok" * it is like "support for slow tests" * allows certain privileged ppl to skip slow tests (those that know the gradle magic) * probably same people are the ones writing slow tests, not having to live with consequences * causes differences across runs of different devs for no good reason we don't need this annotation. we can work together to keep the tests fast. if tests are slow we can all share the pain until we fix the test to be fast. this thing is a real antipattern, i think the idea came from solr, but well, look at their tests. let's not be like them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
