rmuir commented on PR #829: URL: https://github.com/apache/lucene/pull/829#issuecomment-1106757373
It is also bad that your subclass has to override 4 methods and deal with strings at all. These already have default implementations. Let's make the string-based methods `final`. they already has good default implementations, we need to make this kind of thing easier. I also spot bugs in the current code where `FilterPath.endsWith(String)` is deferring to `startsWith()`. This is not helping our cause. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
