mikemccand commented on PR #817: URL: https://github.com/apache/lucene/pull/817#issuecomment-1101500256
+1 this is awesome @rmuir -- the exception message ought to be crystal clear how to resolve the problems, so that new users (who closely read the suggestions in exception messages) know how to proceed. As the message stands today, you can run the command it suggests (style checking just the one fail-fast module, e.g. `./gradlew :lucene:core:spotlessApply`), it succeeds, you open a PR thinking everything is great, and then it fails the top-level `./gradle check` in the GitHub checks. It's trappy for new users. This is what happened in [this incremental commit for this fresh-eyes PR](https://github.com/apache/lucene/pull/807/commits/79b3f722392c2bdccadc442ac6a2c09fc9727c58) with sad/fun commit message `It keeps finding new things ... what's up with this?`. Thank you!! We need to learn from the struggles of every new fresh-eyes developer in our community and fix the potholes for the next new developer. Our community grows only at its periphery. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
