mikemccand commented on PR #807: URL: https://github.com/apache/lucene/pull/807#issuecomment-1101434176
> bq. Since the Spotless check seems to be fail-fast, maybe we should fix the exception message to just suggest ./gradlew tidy instead? > > Gradle runs tasks in parallel so it's not really "fail fast". It's "abort anything not yet started because built will fail". And if multiple things fail, gradle will report all of them (as a list of problems). As any tool, it takes some getting used to - I think these messages are quite fine (and 'tidy' is in fact a non-standard invention of mine... but it's a four letter word so I couldn't resist). Well then I stand by my original fail-fast label LOL ;) Concurrency of the tasks is no excuse. It is a complex build implementation detail, which you obviously deeply understand!! (thank you!!!!! I know migrating to `gradle` was an insane amount of work), that a new person should not need to know, or even know they don't know. From the fresh eyes user's standpoint, it still means that `./gradlew` is not showing all the things wrong with your change. Clearly it confused fresh-eyes here -- look at the commit message above [It keeps finding new things ... what's up with this?](https://github.com/apache/lucene/pull/807/commits/79b3f722392c2bdccadc442ac6a2c09fc9727c58). If we insist on our new users knowing these complex build implementation details then the least we could do is fix the exception message to say `just run ./gradlew check` or `./gradlew tidy`. Otherwise this trap remains for the next fresh eyes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
