Yuti-G commented on code in PR #778:
URL: https://github.com/apache/lucene/pull/778#discussion_r844156099
##########
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java:
##########
@@ -109,7 +109,7 @@ public boolean childrenLoaded() {
* @lucene.experimental
*/
public boolean siblingsLoaded() {
- return children != null;
+ return siblings != null;
Review Comment:
Hi @gsmiller, thanks for your feedback! There is only one use case that I
could find where `siblingsLoaded()` and `childrenLoaded()` can return different
boolean value, and I added a test for it. Please let me know if there is any
question. Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
