[ 
https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517259#comment-17517259
 ] 

ASF subversion and git services commented on LUCENE-10002:
----------------------------------------------------------

Commit b0ecba4fb243d24d083325c7482f9725bccc57db in lucene's branch 
refs/heads/branch_9x from Luca Cavanna
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=b0ecba4fb24 ]

LUCENE-10484: Add support for concurrent facets random sampling (#765)

This commit adds a new createManager static method to 
RandomSamplingFacetsCollector that allows users to perform random sampling 
concurrently. The returned collector manager is very similar to the existing 
FacetsCollectorManager but it exposes a specialized reduced 
RandomSamplingFacetsCollector.

This relates to 
[LUCENE-10002](https://issues.apache.org/jira/browse/LUCENE-10002). It allows 
users to use a collector manager instead of a collector when doing random 
sampling, in the effort of reducing usages of IndexSearcher#search(Query, 
Collector).


> Remove IndexSearcher#search(Query,Collector) in favor of 
> IndexSearcher#search(Query,CollectorManager)
> -----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-10002
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10002
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>          Time Spent: 15h 40m
>  Remaining Estimate: 0h
>
> It's a bit trappy that you can create an IndexSearcher with an executor, but 
> that it would always search on the caller thread when calling 
> {{IndexSearcher#search(Query,Collector)}}.
>  Let's remove {{IndexSearcher#search(Query,Collector)}}, point our users to 
> {{IndexSearcher#search(Query,CollectorManager)}} instead, and change factory 
> methods of our main collectors (e.g. {{TopScoreDocCollector#create}}) to 
> return a {{CollectorManager}} instead of a {{Collector}}?



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to