[
https://issues.apache.org/jira/browse/LUCENE-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517128#comment-17517128
]
Yixun Xu edited comment on LUCENE-10470 at 4/4/22 9:58 PM:
-----------------------------------------------------------
[~ivera] Here is another shape that still fails after the latest fix:
[^polygon3.geojson]
Similar to the first one I reported, this shape can be tessellated with Lucene
8.2.0, but fails with Lucene >= 8.3.0, including the main branch and the branch
of [https://github.com/apache/lucene/pull/756.]
This is the failing shape:
!image-2022-04-04-17-34-41-971.png|width=344,height=254!
The {{signedArea}} check didn't work for this one because the leftover shape
looks like this (plotted from the linked list rooted on the {{start}} node
[here|https://github.com/apache/lucene/pull/756/files#diff-af8dbb3ae12916a76f1b0469fd252a90842e4950395b7c20045924fd866533eaR831]):
!image-2022-04-04-17-33-52-454.png|width=237,height=327!
Edit: I tried re-introducing your ({{{}checkNonColinearLines{}}}) fix into your
branch and it seems to work. I'lll open a branch to show it.
Edit 2: nevermind, that made polygon3 work but made polygon2 fail again, so
it's not the right fix.
was (Author: JIRAUSER286707):
[~ivera] Here is another shape that still fails after the latest fix:
[^polygon3.geojson]
Similar to the first one I reported, this shape can be tessellated with Lucene
8.2.0, but fails with Lucene >= 8.3.0, including the main branch and the branch
of [https://github.com/apache/lucene/pull/756.]
This is the failing shape:
!image-2022-04-04-17-34-41-971.png|width=344,height=254!
The {{signedArea}} check didn't work for this one because the leftover shape
looks like this (plotted from the linked list rooted on the {{start}} node
[here|https://github.com/apache/lucene/pull/756/files#diff-af8dbb3ae12916a76f1b0469fd252a90842e4950395b7c20045924fd866533eaR831]):
!image-2022-04-04-17-33-52-454.png|width=237,height=327!
Edit: I tried re-introducing your (\{{checkNonColinearLines}}) fix into your
branch and it seems to work. I'lll open a branch to show it.
> Unable to Tessellate polygon
> ----------------------------
>
> Key: LUCENE-10470
> URL: https://issues.apache.org/jira/browse/LUCENE-10470
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
> Affects Versions: 9.0
> Reporter: Yixun Xu
> Priority: Major
> Attachments: image-2022-03-16-18-12-43-411.png,
> image-2022-03-31-16-06-33-051.png, image-2022-04-04-17-33-52-454.png,
> image-2022-04-04-17-34-41-971.png, polygon2.geojson, polygon3.geojson,
> vertices-latest-lucene.txt, vertices-lucene-820.txt
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> I have a polygon that causes {{Tessellator.tessellate}} to throw an "Unable
> to Tessellate shape" error. I tried several versions of Lucene, and the issue
> does not happen with Lucene 8.2.0, but seems to happen with all Lucene
> versions >=8.3.0, including the latest main branch.
> I created a branch that reproduces the issue:
> [https://github.com/apache/lucene/compare/main...yixunx:yx/reproduce-tessellator-error?expand=1]
> This is the polygon rendered on geojson.io:
> !image-2022-03-16-18-12-43-411.png|width=379,height=234!
> Is this a bug in the Tesselator logic, or is there anything wrong with this
> polygon that maybe wasn't caught by Lucene 8.2.0?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
