[
https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514917#comment-17514917
]
Tomoko Uchida commented on LUCENE-10485:
----------------------------------------
I'm not trying to make a new test module. Here, we need to convert existing
tests that test package-private methods in the main module. In "in-module"
tests, the built test jar is a self-contained jar that has both main and test
classes by module patching - this means we intentionally (temporarily) create
split packages between "main" and "test"... I'm missing something?
> Limit o.a.l.a.morph package visibility only to kuromoji and nori
> ----------------------------------------------------------------
>
> Key: LUCENE-10485
> URL: https://issues.apache.org/jira/browse/LUCENE-10485
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Tomoko Uchida
> Priority: Minor
> Attachments: hacky-poc-make-kuromoji-test-named-module.patch
>
>
> LUCENE-10393 added a new package {{org.apache.lucene.analysis.morph}} to
> analysis-common that is supposed to be used by only analysis-kuromoji and
> analysis-nori modules. It would be better to reduce its visibility (on
> module-mode) by "export to" clause in the module descriptor.
> The major issue here may be unit tests. They also have to be converted to
> properly named modules otherwise they cannot access the {{o.a.l.a.morph}}
> package.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
