madrob commented on a change in pull request #759:
URL: https://github.com/apache/lucene/pull/759#discussion_r833340902



##########
File path: lucene/benchmark/conf/readContentSource.alg
##########
@@ -24,7 +24,7 @@
 #
 # To use this, first cd to benchmark and then run:
 #
-#   ant run-task -Dtask.alg=conf/readContentSource.alg
+#   gradlew run -P task.alg=conf/readContentSource.alg

Review comment:
       I just checked and from the top level both `./gradlew 
:lucene:benchmark:run -Ptask.alg=conf/standard.alg` and `./gradlew -p 
lucene/benchmark run -Ptask.alg=conf/standard.alg` work to resolve the 
algorithm. I guess the JavaExec task sets the CWD to the sub-project. We don't 
do any special [path 
manipulation](https://github.com/apache/lucene/blob/main/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/Benchmark.java#L103)
   
   The docs clearly state in 
[byTask/package-info.java](https://github.com/apache/lucene/blob/main/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/package-info.java)
 that if you're using custom algorithms you need to provide the full path.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to