jpountz commented on a change in pull request #754: URL: https://github.com/apache/lucene/pull/754#discussion_r830223881
########## File path: lucene/core/src/java/org/apache/lucene/codecs/CompetitiveImpactAccumulator.java ########## @@ -151,9 +151,6 @@ public String toString() { // Only called by assertions private boolean assertConsistent() { - for (int freq : maxFreqs) { - assert freq >= 0; - } Review comment: We spent lots of time there in `Test2BPostings` and tests that index lots of docs in general, while this part of the assertion doesn't yield much value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org