mocobeta edited a comment on pull request #740:
URL: https://github.com/apache/lucene/pull/740#issuecomment-1072278589
> Maybe export org.apache.lucene.analysis.morph only to kuromoji and nori.
First I wanted and tried to do so, but in order to export
"org.apache.lucene.analysis.morph" package only to them, analysis-common
requires kuromoji and nori otherwise it does not know them at all? Maybe I'm
missing something?
I agree that the shared interfaces/implementations shouldn't be fully
public, I'd like to examine the correct way to limit the visibility only to
kuromoji and nori.
For now, I saw compilation fails with warning when I added `to` clause to
`exports`.
```
> Task :lucene:analysis:common:compileJava FAILED
/mnt/hdd/repo/lucene/lucene/analysis/common/src/java/module-info.java:63:
warning: [module] module not found: org.apache.lucene.analysis.kuromoji
exports org.apache.lucene.analysis.morph to
org.apache.lucene.analysis.kuromoji;
```
I'm investigating how to handle that warning. The language spec says "It is
permitted for the to clause of an exports or opens directive to specify a
module which is not observable".
https://docs.oracle.com/javase/specs/jls/se11/html/jls-7.html#jls-7.7.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
