mocobeta commented on a change in pull request #746:
URL: https://github.com/apache/lucene/pull/746#discussion_r826259906
##########
File path:
lucene/distribution.tests/src/test/org/apache/lucene/distribution/TestScripts.java
##########
@@ -112,6 +120,7 @@ protected void execute(
Launcher launcher,
int expectedExitCode,
long timeoutInSeconds,
+ Path logFile,
Review comment:
I added this parameter for proof of concepts, but this can be (should
be) `Optional<Path>`. If None is passed, `processOutputConsumer` would take
stdout of the forked process as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
