[
https://issues.apache.org/jira/browse/LUCENE-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497692#comment-17497692
]
Greg Miller commented on LUCENE-10440:
--------------------------------------
PRs posted for this. The only point maybe worth calling out here for discussion
is that the visibility reduction of {{TaxonomyFacets}} means there is no common
type to refer to just taxonomy-faceting implementations. The only reason I
could see this _maybe_ mattering is that {{TaxonomyFacets}} defines public
methods {{childrenLoaded()}} and {{{}siblingsLoaded(){}}}. So it's possible
some user wants to refer to taxonomy facets generally, but not as general as
just referencing {{Facets}} because they want to rely on one of these methods.
This seems unlikely to me. The only code we have that references these methods
is in testing, but I suppose users might want to know if these things were
loaded for the purpose of metrics/logging/etc.
> Reduce visibility of TaxonomyFacets and FloatTaxonomyFacets
> -----------------------------------------------------------
>
> Key: LUCENE-10440
> URL: https://issues.apache.org/jira/browse/LUCENE-10440
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Greg Miller
> Assignee: Greg Miller
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Similar to what we did in LUCENE-10379, let's reduce the {{public}}
> visibility of {{TaxonomyFacets}} and {{FloatTaxonomyFacets}} to pkg-private
> since they're really implementation details housing common logic and not
> really intended as extension points for user faceting.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
