mocobeta commented on a change in pull request #643: URL: https://github.com/apache/lucene/pull/643#discussion_r802812293
########## File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java ########## @@ -526,4 +526,17 @@ public static void fsync(Path fileToSync, boolean isDir) throws IOException { public interface IOFunction<T, R> { R apply(T t) throws IOException; } + + /** + * A resource supplier function that may throw an IOException. + * + * <p>Note that this would open a resource such as a File. Consumers should make sure to close the + * resource (e.g., use try-with-resources) + * + * @see java.util.function.Supplier + */ + @FunctionalInterface Review comment: It seems there is a bit of disagreement in the API design. I think we'd need to solve this inconsistency in the core util's API to proceed with LUCENE-10400, I will open an issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org