iverase commented on a change in pull request #666:
URL: https://github.com/apache/lucene/pull/666#discussion_r802747917



##########
File path: lucene/core/src/test/org/apache/lucene/util/bkd/TestDocIdsWriter.java
##########
@@ -166,6 +184,9 @@ public Relation compare(byte[] minPackedValue, byte[] 
maxPackedValue) {
               throw new UnsupportedOperationException();
             }
           });
+      // ignore order
+      Arrays.sort(ints);

Review comment:
       Looking into the contract of IntersectVisitor#visit(int docID), it does 
not have any mention on the order so we are not breaking the contract, still 
this might be surprising depending of you r index sort. Let's see what other 
people thinks I am not sure of the right answer here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to