uschindler commented on pull request #643:
URL: https://github.com/apache/lucene/pull/643#issuecomment-1030599745
> Encountered an issue with `@Deprecated(forRemoval = true)`. We can't call
them even from test cases since `@SuppressWarnings("deprecation")` doesn't work
when it is marked as "for removal", and then test compilation fails with
warnings.
>
> ```
> > Task :lucene:analysis:kuromoji:compileTestJava FAILED
>
/mnt/hdd/repo/lucene/lucene/analysis/kuromoji/src/test/org/apache/lucene/analysis/ja/dict/TestTokenInfoDictionary.java:81:
warning: [removal] TokenInfoDictionary(ResourceScheme,String) in
TokenInfoDictionary has been deprecated and marked for removal
> return new TokenInfoDictionary(ResourceScheme.FILE,
dir.resolve(dictionaryPath).toString());
> ```
>
> Do we have to change tests to get rid of the deprecated method calls?
Hi,
as we want to remove the methods anyway (at least in master), fixing the
tests would be a good idea. If we need to maintain test in 9.x testing the old
methods, a `@SuppressWarnings("removal")` would be applicable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
