gautamworah96 commented on a change in pull request #632:
URL: https://github.com/apache/lucene/pull/632#discussion_r799102705
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java
##########
@@ -285,53 +289,42 @@ public DrillSidewaysResult search(
}
final int fTopN = Math.min(topN, limit);
- if (executor != null) { // We have an executor, let use the
multi-threaded version
-
- final CollectorManager<TopFieldCollector, TopFieldDocs>
collectorManager =
- new CollectorManager<>() {
-
- @Override
- public TopFieldCollector newCollector() {
- return TopFieldCollector.create(sort, fTopN, after,
Integer.MAX_VALUE);
- }
-
- @Override
- public TopFieldDocs reduce(Collection<TopFieldCollector>
collectors) {
- final TopFieldDocs[] topFieldDocs = new
TopFieldDocs[collectors.size()];
- int pos = 0;
- for (TopFieldCollector collector : collectors)
- topFieldDocs[pos++] = collector.topDocs();
- return TopDocs.merge(sort, topN, topFieldDocs);
- }
- };
- ConcurrentDrillSidewaysResult<TopFieldDocs> r =
searchConcurrently(query, collectorManager);
- TopFieldDocs topDocs = r.collectorResult;
- if (doDocScores) {
- TopFieldCollector.populateScores(topDocs.scoreDocs, searcher, query);
- }
- return new DrillSidewaysResult(
- r.facets,
- topDocs,
- r.drillDownFacetsCollector,
- r.drillSidewaysFacetsCollector,
- r.drillSidewaysDims);
+ final CollectorManager<TopFieldCollector, TopFieldDocs> collectorManager
=
+ new CollectorManager<>() {
+
+ @Override
+ public TopFieldCollector newCollector() {
+ return TopFieldCollector.create(sort, fTopN, after,
Integer.MAX_VALUE);
+ }
+
+ @Override
+ public TopFieldDocs reduce(Collection<TopFieldCollector>
collectors) {
+ final TopFieldDocs[] topFieldDocs = new
TopFieldDocs[collectors.size()];
+ int pos = 0;
+ for (TopFieldCollector collector : collectors)
+ topFieldDocs[pos++] = collector.topDocs();
+ return TopDocs.merge(sort, topN, topFieldDocs);
+ }
+ };
+ final ConcurrentDrillSidewaysResult<TopFieldDocs> r;
+ if (executor != null) {
+ // We have an executor, let use the multi-threaded version
+ r = searchConcurrently(query, collectorManager);
} else {
+ r = searchSequentially(query, collectorManager);
Review comment:
Yep. This speeds up users who were using this API in a multithreaded
environment!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
