jtibshirani edited a comment on pull request #641: URL: https://github.com/apache/lucene/pull/641#issuecomment-1029284791
Extracting `HnswGraphSearcher` is a lot nicer, I will push a refactor. On the topic of hash sets, I tried switching to `IntIntHashMap` on top of this PR and it gives a nice indexing speed-up. I can open a follow-up PR. About reusing data structures across searches -- I've heard that some other HNSW implementations found this to be beneficial, specifically maintaining a shared pool of "visited" sets for searches to use. It could indeed be complex though, I'd be curious to understand the the magnitude of the improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
