sonatype-lift[bot] commented on a change in pull request #629: URL: https://github.com/apache/lucene/pull/629#discussion_r794441349
########## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/BoundsChecker.java ########## @@ -17,62 +17,74 @@ package org.apache.lucene.util.hnsw; -abstract class BoundsChecker { +/** + * A helper class for an hnsw graph that serves as a comparator of the currently set bound value + * with a new value. + */ +public abstract class BoundsChecker { float bound; /** Update the bound if sample is better */ - abstract void update(float sample); + public abstract void update(float sample); /** Update the bound unconditionally */ - void set(float sample) { + public void set(float sample) { bound = sample; } /** @return whether the sample exceeds (is worse than) the bound */ Review comment: I've recorded this as ignored for this pull request. If you change your mind, just comment `@sonatype-lift unignore`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org