mayya-sharipova commented on a change in pull request #608:
URL: https://github.com/apache/lucene/pull/608#discussion_r790156407
##########
File path:
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswVectorsFormat.java
##########
@@ -77,26 +77,33 @@
static final int VERSION_START = 0;
static final int VERSION_CURRENT = VERSION_START;
+ /** Default number of maximum connections per node */
public static final int DEFAULT_MAX_CONN = 16;
+ /**
+ * Default number of the size the size of the queue maintained while
searching and the number of
+ * random entry points to sample during a graph construction.
+ */
public static final int DEFAULT_BEAM_WIDTH = 100;
/**
* Controls how many of the nearest neighbor candidates are connected to the
new node. Defaults to
* {@link Lucene90HnswVectorsFormat#DEFAULT_MAX_CONN}. See {@link HnswGraph}
for more details.
*/
- private final int maxConn;
+ final int maxConn;
Review comment:
Do you think we may extend `Lucene90HnswVectorsFormat` in other packages?
We are currently using this class and its subclasses only in
`org.apache.lucene.backward_codecs.lucene90` package, that's why packages
private access to these fields should be enough, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
