gsmiller opened a new pull request #613: URL: https://github.com/apache/lucene/pull/613
# Description SSDV faceting needs to know about facet configuration to ensure it properly handles hierarchical faceting and multivalue faceting, but currently allows users to instantiate `DefaultSortedSetDocValuesReaderState` without providing configuration. This is trappy and we should require users to provide their facets config in all cases. # Solution Remove ctors that don't require facets configuration. # Tests Updated all existing tests to provide config. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
