[
https://issues.apache.org/jira/browse/LUCENE-10373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478102#comment-17478102
]
Greg Miller commented on LUCENE-10373:
--------------------------------------
Added a patch file for the change we could test. We need to add benchmarks
though before we can do any meaningful testing though. Since I don't have time
to work on that right now, I'll just park the patch file here if it's useful.
> Can we optimize TaxonomyFacetSumIntAssociations#sumValues?
> ----------------------------------------------------------
>
> Key: LUCENE-10373
> URL: https://issues.apache.org/jira/browse/LUCENE-10373
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Greg Miller
> Priority: Minor
> Attachments: LUCENE-10373.patch
>
>
> It looks like {{TaxonomyFacetSumIntAssociations#sumValues}} might also
> benefit from reduced {{null}} checks just like in LUCENE-10350 (doing away
> with the use of the parent class {{increment}} method).
> While we're at it, it would be nice to test moving to little endian encoding
> of the ord/value since we're trying to deprecate {{{}BitUtil.VH_BE_INT{}}}.
> The real challenge is that we don't have benchmark tasks for this class.
> Maybe we should add benchmarking first? I opened a {{luceneutil}} issue for
> this: https://github.com/mikemccand/luceneutil/issues/158
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
