jtibshirani commented on a change in pull request #601:
URL: https://github.com/apache/lucene/pull/601#discussion_r784334763
##########
File path: lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java
##########
@@ -49,7 +43,7 @@ public abstract void writeField(FieldInfo fieldInfo,
KnnVectorsReader knnVectors
public abstract void finish() throws IOException;
/** Merge the vector values from multiple segments, for all fields */
- public void merge(MergeState mergeState) throws IOException {
+ public final void merge(MergeState mergeState) throws IOException {
Review comment:
In that case, I'll make sure to override `PerFieldKnnVectorsFormat` to
delegate `merge` properly by grouping the writers by field. Maybe I'll remove
the public `KnnVectorsWriter#mergeField` so there's only one method that can be
overridden to keep things simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
