iverase commented on pull request #541: URL: https://github.com/apache/lucene/pull/541#issuecomment-1012044387
I don't like that the optimisation only works for a specific number of points, it feels very tricky. If we are doing something like that we should remove the possibility of users changing the number of points per leaf as it makes no sense any longer to change it? e.g changing it will never give you more performance. I remember in the approach I tried I was batching the docIds by a number (128 or 256) but in general tI didn't see much better performance comparing to the added complexity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org