TomMD commented on a change in pull request #463: URL: https://github.com/apache/lucene/pull/463#discussion_r780437567
########## File path: lucene/core/src/java/org/apache/lucene/search/IndriOrScorer.java ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.search; + +import java.io.IOException; +import java.util.List; + +/** + * Combines scores of subscorers. If a subscorer does not contain the docId, a smoothing score is + * calculated for that document/subscorer combination. + */ +public class IndriOrScorer extends IndriDisjunctionScorer { + + protected IndriOrScorer(Weight weight, List<Scorer> subScorers, ScoreMode scoreMode, float boost) + throws IOException { + super(weight, subScorers, scoreMode, boost); + } + + @Override + public float score(List<Scorer> subScorers) throws IOException { + int docId = this.docID(); + return scoreDoc(subScorers, docId); + } + + @Override + public float smoothingScore(List<Scorer> subScorers, int docId) throws IOException { + return scoreDoc(subScorers, docId); + } + + private float scoreDoc(List<Scorer> subScorers, int docId) throws IOException { + float score = 1; + for (Scorer scorer : subScorers) { + int scorerDocId = scorer.docID(); + // If the query exists in the document, score the document + // Otherwise, compute a smoothing score, which acts like an idf + // for subqueries/terms + double tempScore = 0; + if (docId == scorerDocId) { + tempScore = (1 - Math.exp(scorer.score())); + } else { + tempScore = (1 - Math.exp(scorer.smoothingScore(docId))); + } + score *= tempScore; Review comment: It's saying that something big (double, 64 bit) is being combined into something smaller (float, 32 bit). For example, this is the same concept as warnings you get with C when assigning a variable of type `int` to a variable of type `size_t`. Making `score` a `double` would resolve the warning, though functionality still depends on the magnitude and the floating point multiplication not causing bounds or accuracy issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
