[
https://issues.apache.org/jira/browse/LUCENE-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469993#comment-17469993
]
ASF subversion and git services commented on LUCENE-10353:
----------------------------------------------------------
Commit f2e00bb9e09e82e00cc5389768ab814303ad5fcf in lucene's branch
refs/heads/main from Robert Muir
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=f2e00bb ]
LUCENE-10353: add random null injection to TestRandomChains (#586)
Co-authored-by: Uwe Schindler <[email protected]>, Robert Muir
<[email protected]>
> Add null injection to analyzer integration tests (e.g. TestRandomChains)
> ------------------------------------------------------------------------
>
> Key: LUCENE-10353
> URL: https://issues.apache.org/jira/browse/LUCENE-10353
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Priority: Major
> Labels: random-chains
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> These tests inject random parameter values (from argumentProviders). Some
> generated values may be illegal and IllegalArgumentException is "allowed" if
> the constructor returns it. None of the values should cause failures at
> runtime.
> But for object types, we never inject null values (unless the
> argumentProvider were to do it itself). We should do this some low % of the
> time, and "allow" ctors to return NPE too.
> I see bugs in some of the analyzers where they are just a missing null check
> in the constructor. It is important to fail on invalid configuration up-front
> in the ctor, rather than failing e.g. at index time.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
