uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1003345402
> > > The problem with your patch is that you change public API to suddenly use relative resource names in public ctors. Instead we should deprecate those and add InputStream taking actors. > > > > > > I am 99% (even though not 100%) sure anyone who uses the 2-args protected constructor uses it for loading external resources on their file system (since I know this was introduced to do so for really advanced users), and most users use no-arg constructor (this implicitly loads resources from the default path); but in theory, I agree it can change the behavior of the constructor. > > We should clean that up in a later PR. The quick fix I will use locally is to add another (possibly hidden) enum constant "CLASS". We can fix the problem easier: If an external resource path is passed, we make it absolute by prefixing with a "/". Then I can use your patch easily. Let me do this - thanks anyways. Nevertheless, we should get rid of this and just supply a ctor that takes 3 InputStreams for advanced users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
