spike-liu commented on a change in pull request #464:
URL: https://github.com/apache/lucene/pull/464#discussion_r774310728
##########
File path:
lucene/test-framework/src/java/org/apache/lucene/index/RandomCodec.java
##########
@@ -227,6 +228,7 @@ public RandomCodec(Random random, Set<String> avoidCodecs) {
addDocValues(
avoidCodecs,
+ new DirectDocValuesFormat(),
Review comment:
Thanks for your instructions, Adrien. The following changes have been
made:
- Fix Indentation in RandomCodec.java;
- Remove RAM accounting logic;
- Replace Iterable<Number> with SortedNumericDocValues;
- Replace Iterable<BytesRef> with TermsEnum;
Meanwhile another separate issue
[Lucene-10336](https://issues.apache.org/jira/browse/LUCENE-10336) has been
created for the review: "Use RandomAccessSlice instead of loading giant byte[]
arrays" and I will follow up.
P.S. Sorry for the slow response. Coding & unit test did cost me a lot of
time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
