zhaih commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r772592359
##########
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/memory/DirectPostingsFormat.java
##########
@@ -962,15 +964,22 @@ public ImpactsEnum impacts(int flags) throws IOException {
private int stateUpto;
public DirectIntersectTermsEnum(CompiledAutomaton compiled, BytesRef
startTerm) {
- runAutomaton = compiled.runAutomaton;
- compiledAutomaton = compiled;
+ if (compiled.nfaRunAutomaton != null) {
+ this.runAutomaton = compiled.nfaRunAutomaton;
Review comment:
Hmmm I checked it again and it's a bit complex to merge the
`runAutomaton` and `nfaRunAutomaton` into one, because previously `runAutomaon`
is having public access and kind of wildly used, it's type directly appears in
some public API such as `QueryVisitor#consumesTermsMatching`, so it might take
another PR to try to merge them, I left a todo for now.
An alternative way I'm thinking about is to move those `if` inside the
`CompiledAutomaton`, and only expose methods like `getByteRunnable` so that
people don't manipulate them outside, I'll include that in next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
