[
https://issues.apache.org/jira/browse/LUCENE-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Feng Guo updated LUCENE-10319:
------------------------------
Description:
In LUCENE-10315, I tried to generate a {{ForUtil}} whose {{BLOCK_SIZE=512}}, I
thought it could be simple since it looks like i only need to change the
BLOCK_SIZE, but it turns out that there are a lot of hard code values...
So this is trying to make all hard code value generated from the BLOCK_SIZE in
case we need a ForUtil somewhere else or want to change BLOCK_SIZE in postings
in feature.
I tried to make the BLOCK_SIZE = 64 / 256 and all tests passed, but i can not
think of a clean way to add a unit test for regression testing purpose.
was:
In LUCENE-10315, I tried to generate a {{ForUtil}} whose {{BLOCK_SIZE=512}}, I
thought it could be simple since it looks like i only need to change the
BLOCK_SIZE, but it turns out that there are a lot of hard code values...
So this is trying to make all hard code value generated from the BLOCK_SIZE in
case we need a ForUtil somewhere else or want to change BLOCK_SIZE in postings
in feature.
I tried to make the BLOCK_SIZE = 64 / 256 and all tests passed.
> Make ForUtil#BLOCK_SIZE changeable
> ----------------------------------
>
> Key: LUCENE-10319
> URL: https://issues.apache.org/jira/browse/LUCENE-10319
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/codecs
> Reporter: Feng Guo
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In LUCENE-10315, I tried to generate a {{ForUtil}} whose {{BLOCK_SIZE=512}},
> I thought it could be simple since it looks like i only need to change the
> BLOCK_SIZE, but it turns out that there are a lot of hard code values...
> So this is trying to make all hard code value generated from the BLOCK_SIZE
> in case we need a ForUtil somewhere else or want to change BLOCK_SIZE in
> postings in feature.
> I tried to make the BLOCK_SIZE = 64 / 256 and all tests passed, but i can not
> think of a clean way to add a unit test for regression testing purpose.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
