[ https://issues.apache.org/jira/browse/LUCENE-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ignacio Vera resolved LUCENE-10289. ----------------------------------- Fix Version/s: (was: 9.1) Resolution: Invalid This changes introduced a performance regression tracked in LUCENE-10299. The change has been reverted and we agreed that the issue should be solved in a different way. Closing as invalid. > DocIdSetBuilder#grow() should take a long instead of int > --------------------------------------------------------- > > Key: LUCENE-10289 > URL: https://issues.apache.org/jira/browse/LUCENE-10289 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Ignacio Vera > Assignee: Ignacio Vera > Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > DocIdSetBuilder accepts adding duplicates and therefore it potentially can > accept more than Integer.MAX_VALUE docs. For example, it already holds a > counter internally that is a long. It probably make sense to be able to grow > using a long instead of an int. > > This will allow us to change PointValue.IntersectVisitor#grow() from int to > long and remove some unnecessary dance when we need to bulk add more that > Integer.MAX_VALUE points. > > -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org