uschindler commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757779571



##########
File path: 
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##########
@@ -152,6 +152,14 @@ public Analyzer createAnalyzerFromClassName(String 
analyzerType) {
     }
   }
 
+  private Analyzer defaultAnalyzer() {
+    try {
+      return CustomAnalyzer.builder().withTokenizer("standard").build();

Review comment:
       If analyzers common is a hard dependency we can for sure only use the 
custom analyzer.
   
   If you change to custom analyzer throughout, showing the class name makes no 
sense anymore. Do we have a good toString() for custom analyzer, so you see 
components?
   
   I'd suggest to fill out the default custom analyzer on top with the values 
of StandardAnalyzer.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to