dweiss commented on a change in pull request #460:
URL: https://github.com/apache/lucene/pull/460#discussion_r754563874
##########
File path: lucene/core/src/java/org/apache/lucene/util/fst/Outputs.java
##########
@@ -49,6 +49,20 @@
/** Encode an output value into a {@link DataOutput}. */
public abstract void write(T output, DataOutput out) throws IOException;
+ /** Get the required size of the output before writing */
+ // TODO: this must become abstract
+ public long outputSize(T ouput) {
+ return 1;
+ }
+ ;
Review comment:
Extra semicolons.
##########
File path: lucene/core/src/java/org/apache/lucene/util/fst/FST.java
##########
@@ -1000,6 +1027,98 @@ private void writePresenceBits(
assert bytePos - dest == numPresenceBytes;
}
+ private long estimateNodeAddress(
Review comment:
I can't quite grasp the logic here - have to go back to the fst compiler
about why it's needed, it's been a while.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
