gsmiller commented on pull request #443: URL: https://github.com/apache/lucene/pull/443#issuecomment-974104360
I believe I've addressed all the PR feedback and got an approval from @mikemccand, so I went ahead and merged. Happy to iterate on this further if anyone has additional comments. Thanks again everyone! Somewhat complicated to make this one back-compat, but I think we ended up with a much cleaner solution thanks to all the feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org