[ 
https://issues.apache.org/jira/browse/LUCENE-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17439264#comment-17439264
 ] 

Dawid Weiss edited comment on LUCENE-10223 at 11/5/21, 1:39 PM:
----------------------------------------------------------------

Hmm... So once I ported the tests it turned out that something has changed in 
intervals and it yields different results than before. And in my opinion the 
matches are wrong. For example, previously this query:
{code:java}
fn:containedBy(fox fn:ordered(brown fox dog))
{code}
on this document:
{code:java}
The quick brown fox jumps over the lazy dog
{code}
would previously return this match:
{code:java}
The quick brown >fox< jumps over the lazy dog
{code}
which is correct to me: the "brown-fox-dog" sequence acts as a constraint over 
the source interval. But now it returns this:
{code:java}
The quick >brown fox jumps over the lazy dog<
{code}
TestMatchHighlighter.testStandardQueryParserIntervalFunctions has a number of 
these that fail on main. [~romseygeek] - what do you think?


was (Author: dweiss):
Hmm... So once I ported the tests it turned out that something has changed in 
intervals and it yields different results than before. And in my opinion the 
matches are wrong. For example, previously this query:
{code}
fn:containedBy(fox fn:ordered(brown fox dog))
{code}
ran on this document:
{code}
The quick brown fox jumps over the lazy dog
{code}
would return this match:
{code}
The quick brown >fox< jumps over the lazy dog
{code}
which is correct - the brown-fox-dog sequence acts as a constraint over the 
source interval. But now it returns this:
{code}
The quick >brown fox jumps over the lazy dog<
{code}

TestMatchHighlighter.testStandardQueryParserIntervalFunctions has a number of 
these that fail on main. [~romseygeek] - what do you think?

> Add interval function support to standard query parser
> ------------------------------------------------------
>
>                 Key: LUCENE-10223
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10223
>             Project: Lucene - Core
>          Issue Type: New Feature
>    Affects Versions: 9.1
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>
> This issue adds syntactic support for expressing interval sub-clauses within 
> queries that StandardQueryParser can parse.
>  
> * [ ] add documentation on what the syntax is to the issue and to the code.
> * [ ] update migration guide (may not be compatible)
> * [ ] mention min-should-match operator support for boolean queries.
> * [ ] changes entry



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to