[
https://issues.apache.org/jira/browse/LUCENE-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437013#comment-17437013
]
Dawid Weiss commented on LUCENE-10195:
--------------------------------------
Hi Jerome. I reviewed the PR again - added changes entry, a non-enabled option
to the default gradle.properties. I also corrected unnecessary exclusions in
validateSourcePatterns (.gradle and .idea are at the root level only, so they
only need to be excluded for the root project).
Finally, after some deliberation, I decided to not include changes to
test-related tasks (ecjLint and test). You know our position on the subject of
caching test results and the changes you added (while informative about how
gradle handles such things) add a layer of additional complexity that I don't
think is needed. Maybe it'll change in the future, who knows - if so, your PR
stays and can be a source of code/ inspiration.
I'd also like to correct the renderJavadoc task - I'd like to keep the map for
offline links as it makes it much simpler to configure and maybe add new linked
javadocs later. Can this map be made cacheable by exposing a converting Input
getter method with a list of classes marked Nested and two fields (string and a
file)? So that we can keep using the map but provide more semantics to gradle?
> Add gradle cache option and make some tasks cacheable
> -----------------------------------------------------
>
> Key: LUCENE-10195
> URL: https://issues.apache.org/jira/browse/LUCENE-10195
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Jerome Prinet
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Increase Gradle build speed with help of Gradle built-in features, mostly
> cache and up-to-date checks
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
