[ 
https://issues.apache.org/jira/browse/LUCENE-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435483#comment-17435483
 ] 

ASF subversion and git services commented on LUCENE-10145:
----------------------------------------------------------

Commit 53b40e0fb7048dcc4778310850c859a8ae635272 in lucene's branch 
refs/heads/main from Adrien Grand
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=53b40e0 ]

LUCENE-10145: Revert change to computeMinMax.

This part of the change would call `ArrayUtil#getUnsignedComparator` on a
length that is rarely 4 or 8. In such cases it's better to use
`Arrays#compareUnsigned`.


> Use VarHandles to speedup byte[] comparisons in some cases
> ----------------------------------------------------------
>
>                 Key: LUCENE-10145
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10145
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>             Fix For: main (9.0)
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> I noticed that using Long#compareUnsigned on longs read via VarHandles is 
> significantly faster than calling compareUnsigned directly. There are cases 
> when this could be leveraged easily such as BKDWriter, which often keeps 
> comparing 4-bytes or 8-bytes across byte[] arrays.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to