iverase commented on pull request #371: URL: https://github.com/apache/lucene/pull/371#issuecomment-939995941
>> can't MutablePointValues behave like a single-leaf PointValues instance? The is some friction there. First, in theory we should have the min/max point value for that leaf which currently don't always have (we are throwing a UnsupportedOperationException() ). Another issue is that strictly we are not complying with the PointValues contract that says that for 1D case, we should emit values in a specific order which is not true for MutablePointValues. Finally what happen if the number of points in bigger than Integer.MAX_VALUE? MaxPointPerLeafNode is an integer so we will have trouble representing such structure. I have tried that approach, trying to make MutablePointValues look like a one leaf tree and my feeling is that it makes things much harder, but indeed this patch proposes to add a new abstraction but I was hoping it would reflect better that data structures we are using. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
