janhoy commented on a change in pull request #355:
URL: https://github.com/apache/lucene/pull/355#discussion_r725913472
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -1376,7 +1144,7 @@ def main():
c = parse_config()
scriptVersion = scriptutil.find_current_version()
- if not c.version.startswith(scriptVersion + '.'):
+ if not c.version.startswith(scriptVersion + '.') and c.version !=
scriptVersion:
Review comment:
Earlier the `find_current_version()` would return an `X.Y` version, but
in some refactor sometime, when moving to `scriptutil.py` and using from other
places, it now returns `X.Y.Z`. So I modified this so we once again compare
release-version to "minor" script-version, e.g. `"9.0.0".startsWith("9.0")`.
This allows the smokeTester in `branch_9_0` to be used to smoketest release
9.0.1, 9.0.2 etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
