markrmiller commented on pull request #365:
URL: https://github.com/apache/lucene/pull/365#issuecomment-939394963
On Sat, Oct 9, 2021 at 5:30 PM Robert Muir ***@***.***> wrote:
> Everything works for me if we add --console plain to the echoCp line,
> then it won't add all this terminal-escaped nonsense:
>
> --- a/lucene/jmh/jmh.sh
> +++ b/lucene/jmh/jmh.sh
> @@ -36,7 +36,7 @@ else
> gradleCmd="${gradlew_dir}/gradlew"
> $gradleCmd -q -p ../../ jar
> echo "gradle build done"
> - classpath=$($gradleCmd -q echoCp)
> + classpath=$($gradleCmd -q --console plain echoCp)
> fi
>
> # shellcheck disable=SC2145
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/lucene/pull/365#issuecomment-939370346>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AADNSFGOKOD5ZVVM4RBCJ6LUGC66PANCNFSM5FQRHPMA>
> .
>
Sorry about that, that silly classpath pull has run in at least like 10
environments, which honestly surprises me, I think I even had that in way
back in the start due to trouble and know I’ve usually had to do it for
scripts with Gradle in the past, so should have had it in there regardless.
That darn classpath pull is the main little part that still annoys me in
terms of a more pure jmh experience. There are some little things I can do
to make it a little better still I think at least.
I started looking at the Gradle plug-in for jmh, and that just really
turned me off. It cost me a lot more to get something reasonable setup, but
I prefer Gradle as out of the picture as possible here, and with these
projects, I am not a fan of the typical jmh Uber fat jar approach. Too
brittle, potential irrelevant headaches, slow, unfriendly. With this
approach we at least get some easy universal configuration control and
standard build time update/run iteration times. It’s also simple to run via
IntelliJ with little extra fuss and I like that when starting a benchmark.
The classpath gather weak link bothers me though and now even more that you
hit this. I’m going to think about that a little, at least doge it on the
informational calls that don’t need it like help and lists.
Mark
--
- Mark
http://about.me/markrmiller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
