[ https://issues.apache.org/jira/browse/LUCENE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424781#comment-17424781 ]
Animesh Pandey commented on LUCENE-9431: ---------------------------------------- [~dsmiley] Thanks for explaining this. I've created a patch and attached to the JIRA. JFYI this is my first time working on Lucene so please let me know if there is something I missed. All unit tests under "lucene/highlighter" succeeded with those changes. Please let me know unit tests were to be added. I noticed that there are a lot of unit tests where we have "if (highlighterFieldMatch.getFlags("text").contains(HighlightFlag.WEIGHT_MATCHES)) { ..." in the unit tests. > UnifiedHighlighter: Make WEIGHT_MATCHES the default > --------------------------------------------------- > > Key: LUCENE-9431 > URL: https://issues.apache.org/jira/browse/LUCENE-9431 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/highlighter > Reporter: David Smiley > Priority: Minor > Labels: newdev > Fix For: main (9.0) > > Attachments: LUCENE-9431.patch > > > This mode uses Lucene's modern mechanism of exposing information that > previously required complicated highlighting machinery. It's also likely to > generally work better out-of-the-box and with custom queries. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org