[ 
https://issues.apache.org/jira/browse/LUCENE-10008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424308#comment-17424308
 ] 

Vigya Sharma commented on LUCENE-10008:
---------------------------------------

Thanks [~mikemccand] for reviewing this bug fix PR. The [lucene-solr 
PR|https://github.com/apache/lucene-solr/pull/2573] above addresses your 
comments re: backporting this fix to lucene_8x.

> CommonGramsFilterFactory doesn't respect ignoreCase=true when default 
> stopwords are used
> ----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-10008
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10008
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Chris M. Hostetter
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> CommonGramsFilterFactory's use of the "words" and "ignoreCase" config options 
> is inconsistent with how StopFilterFactory uses them - leading to 
> "ignoreCase=true" not being respected unless "words" is specified...
> StopFilterFactory...
> {code:java}
>   public void inform(ResourceLoader loader) throws IOException {
>     if (stopWordFiles != null) {
>       ...
>     } else {
>       ...
>       stopWords = new CharArraySet(EnglishAnalyzer.ENGLISH_STOP_WORDS_SET, 
> ignoreCase);
>     }
>   }
> {code}
> CommonGramsFilterFactory...
> {code:java}
>   @Override
>   public void inform(ResourceLoader loader) throws IOException {
>     if (commonWordFiles != null) {
>       ...
>     } else {
>       commonWords = EnglishAnalyzer.ENGLISH_STOP_WORDS_SET;
>     }
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to