[ https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423457#comment-17423457 ]
Robert Muir commented on LUCENE-10130: -------------------------------------- Thanks, let's try it out. if it doesn't help our indexing benchmark here, we can always revert it. > HnswGraph could make use of a SparseFixedBitSet.getAndSet > --------------------------------------------------------- > > Key: LUCENE-10130 > URL: https://issues.apache.org/jira/browse/LUCENE-10130 > Project: Lucene - Core > Issue Type: Task > Reporter: Robert Muir > Priority: Major > Attachments: LUCENE-10130.patch > > > Currently HnswGraph uses SparseFixedBitSet "visited" to track where it has > already been. The logic currently looks like this: > {code} > if (visited.get(entryPoint) == false) { > visited.set(entryPoint); > ... logic ... > } > {code} > If SparseFixedBitSet had a {{getAndSet}} (like FixedBitSet), the code could > be: > {code} > if (visited.getAndSet(entrypoint) == false) { > ... logic ... > } > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org