mayya-sharipova commented on a change in pull request #315:
URL: https://github.com/apache/lucene/pull/315#discussion_r717058396
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java
##########
@@ -478,12 +531,25 @@ private void readValue(int targetOrd) throws IOException {
IndexedKnnGraphReader(FieldEntry entry, IndexInput dataIn) {
this.entry = entry;
this.dataIn = dataIn;
+ this.entryNode =
+ entry.numOfLevels == 1 ? 0 :
entry.nodesByLevel.get(entry.numOfLevels - 1)[0];
}
@Override
public void seek(int level, int targetOrd) throws IOException {
+ long graphDataOffset;
+ if (level == 0) {
+ graphDataOffset = entry.ordOffsetsByLevel.get(0)[targetOrd];
+ } else {
+ int targetIndex =
+ Arrays.binarySearch(
+ entry.nodesByLevel.get(level), 0,
entry.nodesByLevel.get(level).length, targetOrd);
+ assert targetIndex >= 0;
Review comment:
Good notice, I've removed unnecessary assertion `assert targetIndex >=
0;` as in this case we will get AIOOBE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
