[ 
https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17420812#comment-17420812
 ] 

Robert Muir commented on LUCENE-10125:
--------------------------------------

I agree, but don't think it needs to be {{tryWriteLong}}. It can be named 
{{writeLong}}. We should just add a ctor check to OutputStreamIndexOutput 
requiring that buffer size is at least 8. This way we never have to fall back 
to super().

E.g. if the buffer is 1K, and it has 1021 bytes in it already, we should just 
call flush() to force it to be emptied a bit earlier. and always write longs 
with VH.

> Investigate indexing throughput regression on NYC Taxis between 2021-04-12 
> and 2021-05-24
> -----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-10125
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10125
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-10125_hack.patch
>
>
> There's been a significant drop in indexing throughput between 2021-04-12 and 
> 2021-05-24 on the NYC Taxis benchmark. Unfortunately several suspects have 
> been merged during that period of time so we might need to git bisect to 
> figure out which one is responsible for the regression. Interestingly the 
> sorted index looks less affected than the non-sorted indexes.
> https://home.apache.org/~mikemccand/lucenebench/sparseResults.html#index_throughput



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to