goankur commented on a change in pull request #282:
URL: https://github.com/apache/lucene/pull/282#discussion_r706535312
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##########
@@ -152,7 +153,8 @@ private FacetResult getDim(String dim, OrdRange ordRange,
int topN) throws IOExc
}
private void countOneSegment(
- OrdinalMap ordinalMap, LeafReader reader, int segOrd, MatchingDocs hits)
throws IOException {
+ OrdinalMap ordinalMap, LeafReader reader, int segOrd, MatchingDocs hits,
Bits liveDocs)
Review comment:
Please see https://github.com/apache/lucene/pull/293/files for the
approach that relies on wrapping `liveDocs` and main `DocIdSeIterator` to avoid
checking `liveDocs` when `hits` is not null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
