mikemccand commented on a change in pull request #2566:
URL: https://github.com/apache/lucene-solr/pull/2566#discussion_r705507752
##########
File path: lucene/benchmark/conf/collector-small.alg
##########
@@ -21,7 +21,7 @@
# Fully Qualified Class Name of a Collector with a empty constructor
# topScoreDocOrdered - Creates a TopScoreDocCollector that requires in
order docs
# topScoreDocUnordered - Like above, but allows out of order
-collector.class=coll:topScoreDocOrdered:topScoreDocUnordered:topScoreDocOrdered:topScoreDocUnordered
+collector.class=coll:topScoreDoc
Review comment:
I think this was because we removed the (overly) specialized
`TopScoreDocXXX` collectors long ago?
##########
File path:
lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/NewAnalyzerTask.java
##########
@@ -42,14 +43,13 @@ public NewAnalyzerTask(PerfRunData runData) {
public static final Analyzer createAnalyzer(String className) throws
Exception{
final Class<? extends Analyzer> clazz =
Class.forName(className).asSubclass(Analyzer.class);
- try {
- // first try to use a ctor with version parameter (needed for many new
Analyzers that have no default one anymore
- Constructor<? extends Analyzer> cnstr =
clazz.getConstructor(Version.class);
- return cnstr.newInstance(Version.LATEST);
Review comment:
And this removal is because we stopped using `Version` to emulate
backwards compatibility for analyzers, long ago also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
