mikemccand commented on a change in pull request #281:
URL: https://github.com/apache/lucene/pull/281#discussion_r703468423
##########
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##########
@@ -3994,6 +3994,9 @@ public static Options parseOptions(String[] args) {
+ " -segment X: only check the specified segments. This can be
specified multiple\n"
+ " times, to check more than one segment, eg
'-segment _2 -segment _a'.\n"
+ " You can't use this with the -exorcise option\n"
+ + " -threadCount X: number of new threads created and used to
check index concurrently.\n"
Review comment:
Maybe just say `number of threads used to check index concurrently`?
I.e. drop the "new" because then I start to wonder if `main` thread counts :)
##########
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##########
@@ -3994,6 +3994,9 @@ public static Options parseOptions(String[] args) {
+ " -segment X: only check the specified segments. This can be
specified multiple\n"
+ " times, to check more than one segment, eg
'-segment _2 -segment _a'.\n"
+ " You can't use this with the -exorcise option\n"
+ + " -threadCount X: number of new threads created and used to
check index concurrently.\n"
+ + " When not specified, this will default to
the number of CPU cores up to 4.\n"
Review comment:
Maybe we should change this default to not cap at `4`? Just use number
of cores? This is command-line execution, which is typically done only once at
a time (versus when `CheckIndex` is invoked from our tests...).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
