mayya-sharipova commented on a change in pull request #267:
URL: https://github.com/apache/lucene/pull/267#discussion_r700560449
##########
File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java
##########
@@ -206,11 +275,65 @@ public void seek(int level, int targetNode) {
upto = -1;
}
+ /**
+ * Positions the graph on the given level. Must be used before iterating
over nodes on this level
+ * with the method {@code nextNodeOnLevel()}.
+ *
+ * <p>Package private access to use only for tests
+ */
+ void seekLevel(int level) {
Review comment:
Great comment. It is indeed confusing.
I've redesigned KnnGraphValues methods to have:
- A single `seekLevel(int level)` to position on a given level
- `seek(targetNode)` to position on an given node of the previously
positioned level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
